Martin Sivák has posted comments on this change. Change subject: core: Use ToStringBuilder in sla classes ......................................................................
Patch Set 1: Code-Review+1 On the other hand, I think it is a good idea to have a code that takes care of this and frees the developer from thinking about it. I it more error resistant this way. Also the curly brackets make it a bit harder to use simple concatenation in toString. I do not have any strong opinion about this, but we should probably use the same approach across the whole project. So I agree with Martin and Moti here. -- To view, visit https://gerrit.ovirt.org/39981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ed7b26ec4fbade8b1f63aaa7138de4e6ce49937 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
