Martin Sivák has posted comments on this change. Change subject: hosted-engine: hosted-engine client, with storage connection timeout ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40392/1/ovirt_hosted_engine_ha/lib/brokerlink.py File ovirt_hosted_engine_ha/lib/brokerlink.py: Line 168: request.append("{0}={1}".format(k, str(v))) Line 169: request = " ".join(request) Line 170: Line 171: try: Line 172: prevTimeout = self._socket.gettimeout(); Why here? If you really have to do this then do it in checked_communicate. 10 seconds is too fast and you can desynchronize agent with broker. Broker will do something slow, but the agent won't know about it. Line 173: self._socket.settimeout(10) Line 174: self._log.debug("Set socket timeout = %d", 10) Line 175: response = self._checked_communicate(request) Line 176: self._socket.settimeout(prevTimeout) -- To view, visit https://gerrit.ovirt.org/40392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
