Martin Sivák has posted comments on this change. Change subject: core: Added affinity rules enforcement manager ......................................................................
Patch Set 7: Code-Review-1 (4 comments) The documentation needs to be improved a lot. Some of the comments describe the code, but having a high level description of the algorithm and goals is more useful. Plus some code de-duplication is probably needed. https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java: Line 31: Created Please replace with proper Javadoc. (And change the IDEA template :) Line 291: vmGroup The same as the other patch. Remove the old groups from uag. https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java: Line 61: Boolean boolean Line 80: getUnifiedAffinityGroups Again? Isn't this part of the canDoAction patch? -- To view, visit https://gerrit.ovirt.org/41092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674666a4e84ca0f4bb3ed7eb96654f2362020d4d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
