Martin Sivák has posted comments on this change. Change subject: New hypervisor interface for remote VDSM over XML-RPC with stats caching ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/41570/7/mom/HypervisorInterfaces/vdsmxmlrpcInterface.py File mom/HypervisorInterfaces/vdsmxmlrpcInterface.py: Line 19: import time Line 20: import functools Line 21: import socket Line 22: Line 23: from vdsm import vdscli > is this the same vdscli provided by vdsm-python package? There should be no real cycle. This is executed from a separate process and uses only the cli. The momIf does not need to be imported and does not execute even if it is. Line 24: from mom.HypervisorInterfaces.HypervisorInterface import HypervisorInterface, \ Line 25: HypervisorInterfaceError Line 26: Line 27: # Time validity of the cache in seconds Line 154: except KeyError as e: Line 155: raise HypervisorInterfaceError("VM %s does not exist" % uuid) Line 156: Line 157: data = {} Line 158: data['uuid'] = id > id? maybe uuid? Uh, how did I missed this? Thanks. Line 159: data['pid'] = vm['pid'] Line 160: data['name'] = vm['vmName'] Line 161: if None in data.values(): Line 162: return None -- To view, visit https://gerrit.ovirt.org/41570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314f39f9020ee257827145a57f585e7921a913e3 Gerrit-PatchSet: 7 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
