Hello Jiří Moskovčák,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/40777

to review the following change.

Change subject: be more verbose when starting the HE VM fails
......................................................................

be more verbose when starting the HE VM fails

Change-Id: Ieb4842048aa690925284d62685156f56485dd41e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150087
Signed-off-by: Jiri Moskovcak <jmosk...@redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-ha 
refs/changes/77/40777/1

diff --git a/ovirt_hosted_engine_ha/agent/hosted_engine.py 
b/ovirt_hosted_engine_ha/agent/hosted_engine.py
index 70dcd89..82c2b61 100644
--- a/ovirt_hosted_engine_ha/agent/hosted_engine.py
+++ b/ovirt_hosted_engine_ha/agent/hosted_engine.py
@@ -898,13 +898,19 @@
                                       " already running according to VDSM")
                     return
 
-                self._log.error("Failed: %s", output[1])
                 raise Exception(output[1])
 
-            self._log.error("Engine VM started on localhost")
+            self._log.info("Engine VM started on localhost")
             return True
         except Exception as e:
-            self._log.error("Failed to start engine VM: %s", str(e))
+            self._log.info("Failed to start engine VM: '%s'. Please check the"
+                           " vdsm logs. The possible reason: the engine has"
+                           " been already started on a different host so this"
+                           " one has failed to acquire the lock and it will"
+                           " sync in a while."
+                           " For more information please visit: "
+                           "http://www.ovirt.org/Hosted_Engine_Howto";
+                           "#EngineUnexpectedlyDown", str(e))
             return False
 
     def _clean_vdsm_state(self):


-- 
To view, visit https://gerrit.ovirt.org/40777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb4842048aa690925284d62685156f56485dd41e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to