Alon Bar-Lev has posted comments on this change.
Change subject: core: transaction: destructor should be at unmanaged object
..
Patch Set 1:
Simone, please check if it works in your sequence.
--
To view, visit https
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: transaction: destructor should be at unmanaged object
..
core: transaction: destructor should be at unmanaged object
The transaction element is a managed
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/42292/4/backend/manager/modules/aaa/src/main/java/org/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: fix pep8 issue
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42456
To unsubscribe, visit https://gerrit.ovirt.org/settings
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: fix pep8 issue
..
packaging: fix pep8 issue
Change-Id: I127e9c5f789fac4bc3ece31364b682d6a25ffc88
Signed-off-by: Alon Bar-Lev
---
M packaging/libexec
Alon Bar-Lev has abandoned this change.
Change subject: log: preventing boolean values to stop logging
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42444
To unsubscribe, visit https://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2: Code-Review-2
please drop this patch, there is no point in discussion.
filtering is supported for
Alon Bar-Lev has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
there is no sense in filtering boolean values.
also, your patch is fundamentally wrong as it
Alon Bar-Lev has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
what you are doing is bad programming practice.
environment keys should be simple and consistent
Alon Bar-Lev has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
and? what is the problem?
how come you sometime store ohostedcons.CloudInit.ROOTPWD as string and
Alon Bar-Lev has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
I am confused.
Not sure how the interaction (ask again) relates to logging.
I am sure that we
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Encrypt password returned to user, add support for Login
On Behalf
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/42291/3/backend/manager
Alon Bar-Lev has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
I am unsure I understand when we have boolean keys in environment.
--
To view, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: build: remove unneeded autogen.sh
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/42404
To unsubscribe, visit https
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: remove unneeded autogen.sh
..
build: remove unneeded autogen.sh
Change-Id: I9f1059d9e7bc4e036f9f5e68ab18cede20e3bf7c
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: remove unneeded autogen.sh
..
build: remove unneeded autogen.sh
Change-Id: I9508f49b6f44be6bb72e3d708c468defd38362ad
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has posted comments on this change.
Change subject: build: remove unneeded autogen.sh
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/42406
To unsubscribe, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt
Alon Bar-Lev has uploaded a new change for review.
Change subject: jobs: build_mock_srcrpm: use configure.ac to detect autoconf
package
..
jobs: build_mock_srcrpm: use configure.ac to detect autoconf package
detection using
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: remove unneeded autogen.sh
..
build: remove unneeded autogen.sh
Change-Id: I9508f49b6f44be6bb72e3d708c468defd38362ad
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: remove unneeded autogen.sh
..
build: remove unneeded autogen.sh
Change-Id: I9f1059d9e7bc4e036f9f5e68ab18cede20e3bf7c
Signed-off-by: Alon Bar-Lev
---
D
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 3:
(10 comments)
https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42292/1/backend/manager/modules/aaa/src/main/java/org/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22:
pending engine side patch.
--
To view, visit https://gerrit.ovirt.org/38547
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation
..
Patch Set 2:
I tried so much to write it properly... but methods used capitals...
--
To view
Alon Bar-Lev has posted comments on this change.
Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42330/1/backend/manager/modules/uutils/src
Alon Bar-Lev has uploaded a new change for review.
Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation
..
uutil: crypto: EnvelopeEncryptDecrypt initial implementation
Change-Id
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 1:
removal of OVIRT-INTERNAL-ENGINE-AUTH-TOKEN ?
--
To view, visit https://gerrit.ovirt.org/42292
To
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add Bearer and Negotiate auth filters
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/42292/1/backend/manager/modules/aaa/src/main/java/org/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
I think it would be nicer if you get interactive password early in the process,
also parsing
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
.
[INFO ] Successful invocation of AUTHENTICATE_CREDENTIALS
[INFO ] AuthnRecord
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
.
$ ./xxx/bin/ovirt-engine-extensions-tool
--extensions-dir=../ovirt-engine-extension-aaa
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
search, not sure why we exit with 1
[FINE ] doQueryClose Return
[FINEST ] Invoke Output
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
in debug please make sure we have all information possible.
1. timestamp
2. thread id
3
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
please add some info messages to separate sections, example:
[INFO ] INITIALIZATION
[INFO
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
.
usage: ./xxx/bin/ovirt-engine-extensions-tool aaa [options] action [options]
AAA
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/java
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: fix pyflakes invalid syntax issue
..
packaging: setup: fix pyflakes invalid syntax issue
Change-Id: Iba304f6cbedbb8d4677c93fbc0b47a28b2e7583d
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fix pyflakes invalid syntax issue
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42290
To unsubscribe, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/java
Alon Bar-Lev has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38547
To unsubscribe, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 45:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/45/ovirt-engine.spec.in
File ovirt-engine.spec.in
Alon Bar-Lev has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38094/10/packaging/bin/pki-enroll-openssh-cert.sh
File
Alon Bar-Lev has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38094/10/packaging/bin/pki-enroll-openssh-cert.sh
File
Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: support serial console
..
Patch Set 11:
> looks like an error in getting a fresh ovirt-host-deploy jar
this is a snapshot it should be gotten e
Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: support serial console
..
Patch Set 11:
have no idea why jenkins fails, it must be something related to the local
artifactory.
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 2:
probably best to add the extensions manager instance into the context, so all
modules can
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/41605/2/backend/manager/extension-tool/src/main
Alon Bar-Lev has submitted this change and it was merged.
Change subject: ovirt-vmconsole: initial implementation
..
ovirt-vmconsole: initial implementation
Change-Id: I45e0b91bb678008dc74ced8622251beccefc82b9
Signed-off-by
Alon Bar-Lev has posted comments on this change.
Change subject: ovirt-vmconsole: initial implementation
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38091
To unsubscribe, visit https
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: support serial console
..
host-deploy: support serial console
Change-Id: I4692f73dc388794ed0b3e1ee8732f2916d9591d2
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: ssh fingerprint using various algorithms
..
pki: ssh fingerprint using various algorithms
Change-Id: I3570f622054b83c66431609e01917f27ef5957a4
Signed-off
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
pki: add pki-enroll-openssh-cert functionality
requires for future usage of openssh certificates.
Change-Id
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: extract ssh public key logic to script
..
packaging: setup: extract ssh public key logic to script
rhel-6 is missing functionality to export
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: cleanup: reset some vars at init
..
pki: cleanup: reset some vars at init
Change-Id: Ifa9017694aa2df5f533896a7edde4b0be89a2162
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: ovirt-vmconsole: initial implementation
..
ovirt-vmconsole: initial implementation
Change-Id: I45e0b91bb678008dc74ced8622251beccefc82b9
Signed-off-by: Alon Bar
Alon Bar-Lev has posted comments on this change.
Change subject: core: fix EKU for VMConsole servlet
..
Patch Set 4:
> unless I'm missing something, that was made already in patch 35887:
>
> https://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: core: fix EKU for VMConsole servlet
..
Patch Set 3:
please update README.oid to allocate your oid
--
To view, visit https://gerrit.ovirt.org/41978
To
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 1:
(12 comments)
https://gerrit.ovirt.org/#/c/41605/1/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 2:
(12 comments)
https://gerrit.ovirt.org/#/c/41605/2/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 44:
this is pending didi
--
To view, visit https://gerrit.ovirt.org/35906
To unsubscribe, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 71:
(1 comment)
https://gerrit.ovirt.org/#/c/36119/71/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core
Alon Bar-Lev has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 71:
(1 comment)
https://gerrit.ovirt.org/#/c/36119/71/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core
Alon Bar-Lev has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 71:
(4 comments)
looks really good!
https://gerrit.ovirt.org/#/c/36119/71/backend/manager/modules/enginesso/src/main/java/org
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 43:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/43/packaging/setup/ovirt_engine_setup/util.py
File
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 12:
ok, didi should review.
please do not forget to update README.oid to allocate your oid.
--
To
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 7:
> looking at what we recently did on the engine PKI, doesn't this
> also requires
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Disable pki renewal for 3.5
..
Patch Set 3: Code-Review+1
still, all I would have done is to return false from expired.
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/41388/4/backend/manager/modules/bll/src/main/java/org
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 7:
(7 comments)
https://gerrit.ovirt.org/#/c/41329/7/packaging/setup/plugins/ovirt-engine-setup
Alon Bar-Lev has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(13 comments)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 1: Verified+1
same as master excluding the imports.
--
To view, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 1: Verified+1
same as master excluding the imports.
--
To view, visit https
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
packaging: setup: pki: use local transaction when extracting PKCS#12
as pki is non
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
packaging: setup: pki: use local transaction when extracting PKCS#12
as pki is non
Alon Bar-Lev has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 65:
(4 comments)
https://gerrit.ovirt.org/#/c/36119/65/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 2:
jenkins issue not related to this change.
--
To view, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 65:
(5 comments)
https://gerrit.ovirt.org/#/c/36119/65/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 2:
last comment is unsupported sequence, it will cause issues in many other
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41820
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 1:
I think this will provide a quick remedy for the phoneme that you
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
packaging: setup: pki: use local transaction when extracting PKCS#12
as pki is non
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Make pki transactional
..
Patch Set 4:
even more ugly... please try to solve this properly.
--
To view, visit https://gerrit.ovirt.org/41642
Alon Bar-Lev has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 65:
(2 comments)
https://gerrit.ovirt.org/#/c/36119/65/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core
Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/41605/1/backend/manager/extension-tool/src/main
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Make pki transactional
..
Patch Set 3:
(2 comments)
the solution should be within the pki scripts not within the setup, create yet
another
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: pki: Do not add empty lines to conf
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41786
To unsubscribe, visit https
1 - 100 of 12319 matches
Mail list logo
