Alon Bar-Lev has posted comments on this change. Change subject: engine, backend: enable vmconsole in host deploy ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41388/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java: Line 143: getVds().getName(), Line 144: getVds().getVdsType().name() Line 145: ); Line 146: } Line 147: installer.setVMConsole(parameters.getEnableSerialConsole()); you can simply set this outside of this scope Line 148: break; Line 149: default: Line 150: throw new IllegalArgumentException( Line 151: String.format( https://gerrit.ovirt.org/#/c/41388/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java: Line 75: Line 76: public VdsOperationActionParameters() { Line 77: authMethod = AuthenticationMethod.Password; Line 78: rebootAfterInstallation = true; Line 79: enableSerialConsole = true; I think that this should be false per default. or at least have the default in vdcoptions. Line 80: } Line 81: Line 82: public VdsStatic getVdsStaticData() { Line 83: return vdsStatic; -- To view, visit https://gerrit.ovirt.org/41388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0503507d3a03789f1f14d3e95c17d121a60c59 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
