Alon Bar-Lev has posted comments on this change. Change subject: services, setup: ovirt-vmconsole integration ......................................................................
Patch Set 45: (1 comment) https://gerrit.ovirt.org/#/c/35906/45/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 592: Line 593: %description setup-plugin-websocket-proxy Line 594: Setup and upgrade specific plugins for websocket-proxy Line 595: Line 596: %package vmconsole-proxy > I find this name confusing. We already have a proxy in the ovirt-vmconsole it will be ovirt-engine-vmconsole-proxy which is actually what it is... not that I mind the name, but it is not that confusing :) Line 597: Summary: %{ovirt_product_name_short} VMconsole Proxy Helper Line 598: Group: %{ovirt_product_group} Line 599: Requires: %{name}-lib >= %{version}-%{release} Line 600: Requires: %{name}-setup-plugin-vmconsole-proxy >= %{version}-%{release} -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 45 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
