Alon Bar-Lev has posted comments on this change. Change subject: tools: extensions-tool: initial implementation aaa ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties: Line 31: Line 32: authn-authenticate_credentials.arg.extension-name.name = extension-name Line 33: authn-authenticate_credentials.arg.extension-name.mandatory = true Line 34: authn-authenticate_credentials.arg.extension-name.type = has_argument Line 35: authn-authenticate_credentials.arg.extension-name.help = Name of authn extension. why do you need extension-name? I tried to run: $ ./xxx/bin/ovirt-engine-extensions-tool --extensions-dir=../ovirt-engine-extension-aaa-ldap/examples-temp.keep/ aaa authn-authenticate_credentials --authz-name=ldap-authn-rhds_corp-redhat --user-name=abarlev --password=pass:test [SEVERE ] Argument(s) 'extension-name' required Line 36: Line 37: authn-authenticate_credentials.arg.user-name.name = user-name Line 38: authn-authenticate_credentials.arg.user-name.mandatory = true Line 39: authn-authenticate_credentials.arg.user-name.type = has_argument -- To view, visit https://gerrit.ovirt.org/41605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches