Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Make pki transactional ......................................................................
Patch Set 3: (2 comments) the solution should be within the pki scripts not within the setup, create yet another workaround is not what we want. https://gerrit.ovirt.org/#/c/41642/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py: Line 67: string.ascii_lowercase + Line 68: string.digits Line 69: ) for i in range(6) Line 70: ), Line 71: ) this should be done by mkstemp Line 72: shutil.copytree( Line 73: oenginecons.FileLocations.OVIRT_ENGINE_PKIDIR, Line 74: self._backup Line 75: ) Line 71: ) Line 72: shutil.copytree( Line 73: oenginecons.FileLocations.OVIRT_ENGINE_PKIDIR, Line 74: self._backup Line 75: ) not sure this copies the attributes. Line 76: Line 77: def abort(self): Line 78: if self._backup is not None and os.path.exists(self._backup): Line 79: tmp = '{path}-{time}-{rnd}'.format( -- To view, visit https://gerrit.ovirt.org/41642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b25a3febc9fa80ea980b9b284d99a5459217b9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
