Alon Bar-Lev has posted comments on this change. Change subject: tools: extensions-tool: initial implementation aaa ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java: Line 586: for (String f : (List<String>)actionArgs.get("flags")) { Line 587: if(f.equals("resolve-groups")) { Line 588: flags += 1; Line 589: } else if (f.equals("resolve-groups-recursive")) { Line 590: flags += 2; why do you hard code the flags? Line 591: } Line 592: } Line 593: } Line 594: return flags; -- To view, visit https://gerrit.ovirt.org/41605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
