Alon Bar-Lev has posted comments on this change. Change subject: tools: extensions-tool: initial implementation aaa ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java: Line 547: } Line 548: Line 549: private void printPrincipalRecord(ExtMap extMap) { Line 550: if (extMap != null) { Line 551: logger.info(String.format("PrincipalRecord: ID %s, name: %s, display name: %s, email: %s, first name: %s, last name: %s, department: %s, title: %s", missing NAMESPACE Line 552: extMap.get(Authz.PrincipalRecord.ID, ""), Line 553: extMap.get(Authz.PrincipalRecord.NAME, ""), Line 554: extMap.get(Authz.PrincipalRecord.DISPLAY_NAME, ""), Line 555: extMap.get(Authz.PrincipalRecord.EMAIL, ""), Line 548: Line 549: private void printPrincipalRecord(ExtMap extMap) { Line 550: if (extMap != null) { Line 551: logger.info(String.format("PrincipalRecord: ID %s, name: %s, display name: %s, email: %s, first name: %s, last name: %s, department: %s, title: %s", Line 552: extMap.get(Authz.PrincipalRecord.ID, ""), missing: PRINCIPAL which is very important Line 553: extMap.get(Authz.PrincipalRecord.NAME, ""), Line 554: extMap.get(Authz.PrincipalRecord.DISPLAY_NAME, ""), Line 555: extMap.get(Authz.PrincipalRecord.EMAIL, ""), Line 556: extMap.get(Authz.PrincipalRecord.FIRST_NAME, ""), Line 570: } Line 571: Line 572: private void printGroupRecord(ExtMap extMap) { Line 573: if (extMap != null) { Line 574: logger.info(String.format("GroupRecord: ID %s, name: %s, Display name: %s", missing NAMESPACE Line 575: extMap.get(Authz.GroupRecord.ID, ""), Line 576: extMap.get(Authz.GroupRecord.NAME, ""), Line 577: extMap.get(Authz.GroupRecord.DISPLAY_NAME, "") Line 578: )); Line 573: if (extMap != null) { Line 574: logger.info(String.format("GroupRecord: ID %s, name: %s, Display name: %s", Line 575: extMap.get(Authz.GroupRecord.ID, ""), Line 576: extMap.get(Authz.GroupRecord.NAME, ""), Line 577: extMap.get(Authz.GroupRecord.DISPLAY_NAME, "") missing recursion Line 578: )); Line 579: } Line 580: Line 581: } -- To view, visit https://gerrit.ovirt.org/41605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
