Alon Bar-Lev has posted comments on this change.
Change subject: tools: extensions-tool: initial implementation aaa
......................................................................
Patch Set 3:
.
[INFO ] Successful invocation of AUTHENTICATE_CREDENTIALS
[INFO ] AuthnRecord: {Extkey[name=AAA_AUTHN_AUTH_RECORD_PRINCIPAL;type=class
java.lang.String;uuid=AAA_AUTHN_AUTH_RECORD_PRINCIPAL[c3498f07-11fe-464c-958c-8bd7490b119a];]=abarlev}
[INFO ] PrincipalRecord: ID , name: , display name: , email: , first name: ,
last name: , department: , title:
[INFO ] Groups of PrincipalRecord:
[INFO ] End of groups of PrincipalRecord:
[WARNING] Extension doesn't support logout action
[INFO ] login-user action completed
issues:
1. I expect in general to have a log before and after each invoke we use, in
the above there are missing steps that should be visible also in INFO level.
2. The principal record is empty for some reason.
3. absent of logout is valid condition it should not be a warning.
4. same here, exit code is 1 instead of 0
--
To view, visit https://gerrit.ovirt.org/41605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
