Alon Bar-Lev has posted comments on this change.

Change subject: tools: extensions-tool: initial implementation aaa
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/41605/2/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java
File 
backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java:

Line 277:                 
getExtensionByName((String)this.actionArgs.get("authz-name"))
Line 278:             );
Line 279:         } catch (Exception ex) {
Line 280:             throw new RuntimeException(ex);
Line 281:         }
> In this module no
you can if you want, no?
Line 282:         logger.info("search action completed");
Line 283:     }
Line 284: 
Line 285:     private ExtMap logoutUser(ExtMap authRecord, ExtensionProxy 
authnExtension) {


Line 375:         throw new IllegalArgumentException(String.format("Profile 
'%1$s' not found"));
Line 376:     }
Line 377: 
Line 378:     private ExtensionProxy getExtensionByName(String name) {
Line 379:         return ((Map<String, ExtensionProxy>) 
context.get(EXTENSIONS_MAP)).get(name);
> I am not aware of it, I'll check
this is what I probably meant above as well... :)
Line 380:     }
Line 381: 
Line 382:     private ExtUUID getEntity() throws NoSuchFieldException, 
IllegalAccessException {
Line 383:         return (ExtUUID)Authz.QueryEntity.class.getDeclaredField(


-- 
To view, visit https://gerrit.ovirt.org/41605
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to