Alon Bar-Lev has uploaded a new change for review. Change subject: jobs: build_mock_srcrpm: use configure.ac to detect autoconf package ......................................................................
jobs: build_mock_srcrpm: use configure.ac to detect autoconf package detection using automake artifact for autoconf package is incorrect, as automake is not mandatory. the recommendation in [1][2] are to detect autoconf package using configure.ac file as this file marks usage of autoconf explicitly. [1] http://www.ovirt.org/Build_Install_RPM [2] https://projects.engineering.redhat.com/browse/RHEVINTEG-1045 Change-Id: Ic31f4d20ecf4b7f10af3ba8587e79ae752b1f7ae Signed-off-by: Alon Bar-Lev <alo...@redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/jenkins refs/changes/40/42440/1 diff --git a/jobs/confs/shell-scripts/build_mock_srcrpm.sh b/jobs/confs/shell-scripts/build_mock_srcrpm.sh index efde6f3..92ae07a 100644 --- a/jobs/confs/shell-scripts/build_mock_srcrpm.sh +++ b/jobs/confs/shell-scripts/build_mock_srcrpm.sh @@ -185,7 +185,7 @@ cd /tmp/$project if [[ -x autogen.sh ]]; then ./autogen.sh --system "${{extra_autogen_options[@]}}" - elif [[ -e Makefile.am ]]; then + elif [[ -e configure.ac ]]; then autoreconf -ivf fi [[ -x configure ]] && -- To view, visit https://gerrit.ovirt.org/42440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic31f4d20ecf4b7f10af3ba8587e79ae752b1f7ae Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
