Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 71: (1 comment) https://gerrit.ovirt.org/#/c/36119/71/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java: Line 96: throw new AuthenticationException(String.format("Cannot authenticate user '%s': %s", credentials == null ? "N/A" : credentials.getUsername(), ex.getMessage())); Line 97: } Line 98: } Line 99: Line 100: private static void issueTokenUsingHttpHeaders(HttpServletRequest request, HttpServletResponse response, String redirectUri) throws Exception { this should be iterative, similar to what we have in nego. calling all extensions in order until extensions done. Line 101: log.debug("Entered issueTokenUsingHttpHeaders"); Line 102: Credentials credentials = null; Line 103: try { Line 104: String code = ExternalAuthUtils.doAuth(request, response, false); -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 71 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
