Alon Bar-Lev has posted comments on this change. Change subject: tools: extensions-tool: initial implementation aaa ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41605/1/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties: Line 57: authn-authenticate_credentials.help.header = Authn action of aaa interface test module Line 58: authn-authenticate_credentials.help.usage = @PROGRAM_NAME@ aaa login [options] Line 59: authn-authenticate_credentials.help.footer = \ Line 60: Example:\n\ Line 61: \ @PROGRAM_NAME@ aaa authn-authenticate_credentials --extension-name=my_ldap-authn --user-name=user > Should we get authz info from authn extension, or let user specify? let the user specify Line 62: Line 63: Line 64: login-user.arg.profile-name.name = profile-name Line 65: login-user.arg.profile-name.mandatory = true Line 98: search.arg.authz-name.help = Name of authz extension to perform search with Line 99: Line 100: search.arg.namespace.name = namespace Line 101: search.arg.namespace.type = has_argument Line 102: search.arg.namespace.help = Namespace to search within > I am not sure I understand. Why we need to perform anything to authn within oh... unrelated to search :) info is handy... for search the info should present the namespaces. I think that flags etc... are also good. think of someone who writes an extension and we can view that it supports change credentials, or it is nego etc... Line 103: Line 104: search.arg.entity.name = entity Line 105: search.arg.entity.mandatory = true Line 106: search.arg.entity.type = has_argument -- To view, visit https://gerrit.ovirt.org/41605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
