shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156833064
@gsmiller @mdmarshmallow in the last commit I refactored `FacetSet` to be an abstract class with a concrete `LongFacetSet` impl. I struggled back-and-forth between introducing a `public final long[] comparableLongs` on the abstract `FacetSet` to the `getComparableLongs()` method. I went with the latter approach. Thoughts? Preferences? Also since I want to expose the raw values in each `FS`, having `DoubleFS` extend `LongFS` is not possible without exposing two fields from `DoubleFS` which I don't think that we want. Anyway I'm open to suggestions :). I also think it will be good to demonstrate somewhere, in the `.adoc`, `demo` package or tests how one can implement a specific mix-and-match `FS`, e.g. one that takes a long, int and float dimension values (we should build a story around that) together with a matching `FacetSetDecoder`. This will also prove that it's doable and that we won't break the API in ways that will prevent such impls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
