mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156800419
I took a look at the API and seeing if we could do something there with generics, but that overcomplicates the API haha. It looks good to me! Maybe one thing would be that we want to make it mandatory for a `FacetSet` to implement its own `decode()` function? Also +1 to making a `LongFacetSet`, I think it will make the API much more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
