shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156131175
> Rather than do this, I think that it makes more sense for the impls to just have the ability of returning their own values as a `long[]` (something like `getComparableLongs()` that was in the original `hyperrectangle` package). That way, we won't need to run the reader on every `long[]` we read from the DV but instead can compare it directly with `FacetSet#getComparableLongs()`. I think this would be more efficient? I pushed a commit which showcases how I _think_ we can (1) support custom encoding by `FacetSet` implementations and a `FacetSetDecoder` which knows how to read them. The matching side still happens on comparable `long[]` however now the encoding can use less bytes for e.g. integer and floats dimensions. I also added a `testIntFacetSetMatching` to show how to use the `IntFacet` and corresponding decoder. I didn't implement a test for Double/Float yet, I want us to digest the API and agree that it's what we want. If we're OK w/ this proposal, then we should address all of @gsmiller comments and beef up the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
