shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159374588
> My only suggestion here might be to rename `LongRange` to just `Range` Yeah `LongRange` now feels like there are missing `Int/Float/DoubleRange` which is not the case. But maybe in order to give it a more purposeful name we can name it `Dim/DimensionRange`? > Also, should we add `double` and `float` methods to `FacetSetDecoder`? I don't think so? `FSD` is currently about decoding the encoded `byte[]` into a `long[]` for `FacetSetMatcher` purposes. I assume you're thinking about a user-level API which can decode the values back into a `FacetSet` right? Feels to me like we can do it later too, and I think we'll need a diff API for that, maybe a `FacetSetReader` with `FacetSet[] fromBytes(BytesRef)` or maybe add to `FacetSet` an `unpackValues` method? I prefer though that we focus in this PR on the indexing + matching, to get this PR to completion and also since it doesn't currently feel to me like a necessary API to use facet sets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
