shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156805329
> Maybe one thing would be that we want to make it mandatory for a `FacetSet` to implement its own `decode()` function? I've been there :). The reason I went w/ the static method and functional interface `FacetSetDecoder` is so that you don't have to construct an instance of a `FacetSet` only to use its `decode()` method. Essentially we'd want an `IntFacetSetDecoder` and `LongFacetSetDecoder` as they address int/float and long/double respectively. I can factor the two methods out to their own `FSD` extension if you think it will be more clear? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
