mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156990982
I like the `getComparableLongs()` approach better as well. I also think a demo is a good idea, I can create one later today or tomorrow if you don't get around to it before then. Also another thing I realized is that `RangeFacetSetMatcher` is a bit awkward now, as it actually is only specific to `long`'s. I added the ability to use `FacetSet`'s to define ranges (as long as they implement the `RangeMatching` interface). Let me know what you guys think of the changes. There is also an example of what the new `RangeFacetSetMatcher` interface will look like in the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
