shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159454008
I pushed a commit which: 1. Adds demo code for a `TemperatureReading` `FacetSet` and `FacetSetMatcher`. 2. Modifies the existing Exact and Range matcher float/double tests to properly test float/double values. 3. Introduces default implementations of `packValues` and `sizePackedBytes` which uses `getComparableLongs`. I think this (1) clarifies why one would need to implement `getComparableLongs` and (2) provides a simple default for custom facet sets who don't care about the encoding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
