shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156786518
> I wonder if we shouldn't make `FacetSet` abstract and create a `LongFacetSet` for the long-specific impl I've contemplated on it when I wrote it. I like the idea of an explicit `LongFacetSet` to make it clear. The `long[]` in `FacetSet` though is used to match the dimensions. So now a user can index `IntFacetSet` and for matching construct an `FSM` with an `IntFacetSet` which translates the integers to comparable `long[]`. Then the matcher uses the read `long[]` dimension values to match to the given `comparableLong[]` ones. I'll see if I can rename it better so it's more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
