shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159376910
> It feels overly complicated to introduce `FacetSetRange<...>` and then require the different `FacetSet` implementations to implement these methods to deal with inclusive/exclusive boundaries. I agree, it's a good point. These ranges are not an attribute of a `FacetSet` and we shouldn't force custom implementations to implement that. I feel that the `fromInts/Longs/Floats/Double` gives users what they need to use `RangeFSM`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
