shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1157279381
> Also another thing I realized is that `RangeFacetSetMatcher` is a bit
awkward now, as it actually is only specific to `long`'s
It's actually not only specific to longs. It uses longs to compare to
ranges, like the HyperRectangle did. I took a look at your change and I've
implemented something which I think is much more simple:
* Add to `RangeFacetSetMatcher` `fromLongs()` and `fromDoubles()` which
return a `LongRange` which only has a `min/max` inclusive ranges.
* I don't think that we need to add an interface, nor have code like this to
define a range. It's too cumbersome IMO, requires all 4 parameters to "align"
on the size of the array:
```
new LongFacetSet(FORD_ORD, 2010),
new boolean[] {true, true},
new LongFacetSet(FORD_ORD, 2014),
new boolean[] {true, true})),
```
I also added a `testDoubleRange()` to showcase how simple it looks. I am not
sure how to push the commit though without overriding your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
