gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156708360
@shaie I like this API approach to supporting other data types. Thanks! I wonder if we shouldn't make `FacetSet` abstract and create a `LongFacetSet` for the long-specific impl (and `DoubleFacetSet` could extend it). It feels a little weird to me that `intFacetSet` / `FloatFacetSet` contain `long[]` member fields that go unused. Thoughts? I'll leave a couple small comments on the updated implementation here shortly as well, but I'm +1 on this approach to supporting other data types. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
