shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156829025
> I think we should also have some subpackages (maybe a `decoders`, `matchers`, and `sets` (for `FacetSets`))? Take a look at the last commit: not sure there's a reason for `decoders` at this point, since I've only added the interface w/ two static impls `decodeLongs` and `decodeInts`. Also `matchers` will hold 3 classes? Seems a bit overkill to me, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
