mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1156101105
> To complement that on the aggregation side we will need to pass a reader which can convert the BytesRef to a long[]. I'm thinking that the Int/Float/Long/DoubleFacetSet impls will do that. Rather than do this, I think that it makes more sense for the impls to just have the ability of returning their own values as a `long[]` (something like `getComparableLongs()` that was in the original `hyperrectangle` package). That way, we won't need to run the reader on every `long[]` we read from the DV but instead can compare it directly with `FacetSet#getComparableLongs()`. I think this would be more efficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
