[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #41: to be reusable

slawekjaranowski commented on pull request #41: URL: https://github.com/apache/maven-gh-actions-shared/pull/41#issuecomment-1077275428 We have such in v2 https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/release-drafter.yml This is propably used for repo it

[jira] [Closed] (SUREFIRE-2038) Upgrade Maven Parent to 35

[ https://issues.apache.org/jira/browse/SUREFIRE-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2038. - Resolution: Fixed > Upgrade Maven Parent to 35 > -- >

[GitHub] [maven-surefire] slawekjaranowski merged pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

slawekjaranowski merged pull request #491: URL: https://github.com/apache/maven-surefire/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo

[ https://issues.apache.org/jira/browse/MENFORCER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511563#comment-17511563 ] Duo Zhang commented on MENFORCER-413: - OK, the problem is that, spring-data-common

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833818854 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833818854 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833686568 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

Tibor17 commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833757390 ## File path: pom.xml ## @@ -371,48 +370,22 @@ + org.apache.maven.plugins - maven-shade-plugin

[GitHub] [maven-surefire] Tibor17 commented on pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

Tibor17 commented on pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#issuecomment-1076897776 > question answered. ok, `-Xdoclint:all` is at the [line](https://github.com/apache/maven-surefire/pull/491/commits/6dfb3a828540024cf17ee7e339b7f2b2ec726d5b#diff-9c5

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

Tibor17 commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833757390 ## File path: pom.xml ## @@ -371,48 +370,22 @@ + org.apache.maven.plugins - maven-shade-plugin

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

Tibor17 commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833757390 ## File path: pom.xml ## @@ -371,48 +370,22 @@ + org.apache.maven.plugins - maven-shade-plugin

[jira] [Closed] (SUREFIRE-2042) Remove unused method TestListResolver#getWildcard

[ https://issues.apache.org/jira/browse/SUREFIRE-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2042. - Fix Version/s: 3.0.0-M6 Resolution: Fixed > Remove unused method TestLi

[GitHub] [maven-surefire] slawekjaranowski merged pull request #497: [SUREFIRE-2042] Remove unused method TestListResolver#getWildcard

slawekjaranowski merged pull request #497: URL: https://github.com/apache/maven-surefire/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

slawekjaranowski commented on pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#issuecomment-1076818067 question answered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

slawekjaranowski commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833718240 ## File path: pom.xml ## @@ -371,48 +370,22 @@ + org.apache.maven.plugins - maven-shad

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

slawekjaranowski commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833716724 ## File path: pom.xml ## @@ -371,48 +370,22 @@ + org.apache.maven.plugins - maven-shad

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

Tibor17 commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833698939 ## File path: pom.xml ## @@ -371,48 +370,22 @@ + org.apache.maven.plugins - maven-shade-plugin

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833686568 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on pull request #491: [SUREFIRE-2038] Upgrade Maven Parent to 35

Tibor17 commented on pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#issuecomment-1076779870 @slawekjaranowski I approved maybe too early, we need to check the Javadoc by the compiler with `-Xdoclint:all`. Checking it during Site is too late. The contributors

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833651677 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java #

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833651677 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java #

[jira] [Commented] (MNG-7439) Make fields of CliRequest protected

[ https://issues.apache.org/jira/browse/MNG-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511430#comment-17511430 ] Michael Osipov commented on MNG-7439: - We obviously need a request builder for this. >

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#issuecomment-1076625692 Remove of getWildcard #497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #497: [SUREFIRE-2042] Remove unused method TestListResolver#getWildcard

slawekjaranowski opened a new pull request #497: URL: https://github.com/apache/maven-surefire/pull/497 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) f

[jira] [Created] (SUREFIRE-2042) Remove unused method TestListResolver#getWildcard

Slawomir Jaranowski created SUREFIRE-2042: - Summary: Remove unused method TestListResolver#getWildcard Key: SUREFIRE-2042 URL: https://issues.apache.org/jira/browse/SUREFIRE-2042 Project: Maven

[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #71: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2

slawekjaranowski commented on pull request #71: URL: https://github.com/apache/maven-apache-parent/pull/71#issuecomment-1076585891 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #74: Bump maven-compiler-plugin from 3.10.0 to 3.10.1

slawekjaranowski commented on pull request #74: URL: https://github.com/apache/maven-apache-parent/pull/74#issuecomment-1076573262 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #73: Bump maven-dependency-plugin from 3.2.0 to 3.3.0

slawekjaranowski commented on pull request #73: URL: https://github.com/apache/maven-apache-parent/pull/73#issuecomment-1076573630 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #72: Stage site build (that uses site-pom.xml)

slawekjaranowski commented on pull request #72: URL: https://github.com/apache/maven-apache-parent/pull/72#issuecomment-1076570581 `ff-site-goal` is input parameter for shared actions https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml

[GitHub] [maven-apache-parent] slawekjaranowski merged pull request #72: Stage site build (that uses site-pom.xml)

slawekjaranowski merged pull request #72: URL: https://github.com/apache/maven-apache-parent/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833460524 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java #

[GitHub] [maven-mvnd] ppalaga commented on a change in pull request #612: Make `DaemonRegistry.getProcessId0` more robust

ppalaga commented on a change in pull request #612: URL: https://github.com/apache/maven-mvnd/pull/612#discussion_r833389706 ## File path: common/src/main/java/org/mvndaemon/mvnd/common/DaemonRegistry.java ## @@ -271,23 +271,35 @@ private void reset() { private static fina

[jira] [Commented] (MNG-7439) Make fields of CliRequest protected

[ https://issues.apache.org/jira/browse/MNG-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511307#comment-17511307 ] Thomas Zub commented on MNG-7439: - I want to use maven-embedder to execute Maven commands t

[jira] [Commented] (MNG-7439) Make fields of CliRequest protected

[ https://issues.apache.org/jira/browse/MNG-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511304#comment-17511304 ] Michael Osipov commented on MNG-7439: - What are you trying to achieve? > Make fields o

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r85827 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r85827 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833327718 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi

[jira] [Created] (MNG-7439) Make fields of CliRequest protected

Thomas Zub created MNG-7439: --- Summary: Make fields of CliRequest protected Key: MNG-7439 URL: https://issues.apache.org/jira/browse/MNG-7439 Project: Maven Issue Type: Improvement Compone

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833272523 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; +

[jira] [Created] (MJAVADOC-708) How to get javadoc "locale" configuration from a Taglet in jdk9

DavidHsing created MJAVADOC-708: --- Summary: How to get javadoc "locale" configuration from a Taglet in jdk9 Key: MJAVADOC-708 URL: https://issues.apache.org/jira/browse/MJAVADOC-708 Project: Maven Javado

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833269756 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java #

[GitHub] [maven-mvnd] jglick commented on a change in pull request #612: Make `DaemonRegistry.getProcessId0` more robust

jglick commented on a change in pull request #612: URL: https://github.com/apache/maven-mvnd/pull/612#discussion_r833233006 ## File path: common/src/main/java/org/mvndaemon/mvnd/common/DaemonRegistry.java ## @@ -271,23 +271,35 @@ private void reset() { private static final

[jira] [Commented] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo

[ https://issues.apache.org/jira/browse/MENFORCER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511200#comment-17511200 ] Duo Zhang commented on MENFORCER-413: - I also faced this issue and for my usage, a

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833158290 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833158290 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833155118 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833099924 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833099924 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi

[jira] [Commented] (MNG-7437) Optional profiles that are not found logs warning twice

[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511160#comment-17511160 ] Michael Osipov commented on MNG-7437: - The consistency idea is sound. > Optional profi

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833043025 ## File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm ## @@ -411,6 +413,41 @@ Using JUnit 5 Platform +---+ +** JUnit5

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833036439 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java #

[GitHub] [maven] mthmulders commented on pull request #687: actually the “return” can be writed in the last

mthmulders commented on pull request #687: URL: https://github.com/apache/maven/pull/687#issuecomment-1076128878 Thanks for your contribution, @Gakiii! Two remaining things: 1. Would it be possible for you to explicitly declare this contribution to be licensed under the [Apache Li

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832996983 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[jira] [Commented] (SUREFIRE-2039) Skipped test classes are getting into the non-skipped test classes reports

[ https://issues.apache.org/jira/browse/SUREFIRE-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511132#comment-17511132 ] Tibor Digana commented on SUREFIRE-2039: Thank you as well. We will do our bes

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832996983 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832996983 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832996983 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832996983 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -275

[jira] [Comment Edited] (MNG-7437) Optional profiles that are not found logs warning twice

[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511099#comment-17511099 ] Giovanni van der Schelde edited comment on MNG-7437 at 3/23/22, 8:27 AM:

[jira] [Commented] (MNG-7437) Optional profiles that are not found logs warning twice

[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511099#comment-17511099 ] Giovanni van der Schelde commented on MNG-7437: --- Perhaps it would be an idea

[GitHub] [maven-resolver] cstamas edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

cstamas edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1076065668 > @cstamas Should I create a JIRA for the reuse of [node children cache](https://github.com/bfs-skip/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org

[GitHub] [maven-resolver] cstamas commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

cstamas commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1076065668 > @cstamas Should I create a JIRA for the reuse of [node children cache](https://github.com/bfs-skip/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclips

[GitHub] [maven-resolver] cstamas commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

cstamas commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1076064604 @michael-o @caiwei-ebay @ibabiankou where are we with this PR? IMO, it should be safe to merge, especially as I mentioned, I plan to retain "old" (DFS) resolver as well, t

[jira] [Commented] (SUREFIRE-2039) Skipped test classes are getting into the non-skipped test classes reports

[ https://issues.apache.org/jira/browse/SUREFIRE-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511089#comment-17511089 ] Semyon Danilov commented on SUREFIRE-2039: -- Thank you, got it! I will get to

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832899381 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java #

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832883253 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; +