[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

[GitBox]

slawekjaranowski commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832899381



##########
File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest 
buildLauncherDiscoveryRequestForRerunFailures(
                 .map( TagFilter::excludeTags )
                 .ifPresent( filters::add );
 
-        TestListResolver testListResolver = 
parameters.getTestRequest().getTestListResolver();
-        if ( !testListResolver.isEmpty() )
+        TestListResolver filter = optionallyWildcardFilter( 
parameters.getTestRequest().getTestListResolver() );
+        if ( !filter.isEmpty() && !filter.isWildcard() )

Review comment:
       Is it not the same?:
   
   ```
   TestListResolver testListResolver = 
parameters.getTestRequest().getTestListResolver();
   
   if (  testListResolver.hasMethodPatterns() ) 
   ...
   ```
   
   if true IT test doesn't cover this `if`  with param 
`<test>JUnit5Tests</test>`
   
   For such change we should add unit test in `JUnitPlatformProviderTest`
   with assertions for filters ... 
   
   Another case you change logic here .. but all unit test still pass, looks 
like missing tests or assertions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org