slawekjaranowski commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833036439
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest
buildLauncherDiscoveryRequestForRerunFailures(
.map( TagFilter::excludeTags )
.ifPresent( filters::add );
- TestListResolver testListResolver =
parameters.getTestRequest().getTestListResolver();
- if ( !testListResolver.isEmpty() )
+ TestListResolver filter = optionallyWildcardFilter(
parameters.getTestRequest().getTestListResolver() );
+ if ( !filter.isEmpty() && !filter.isWildcard() )
Review comment:
ok,
```java
public static TestListResolver optionallyWildcardFilter(
TestListResolver resolver )
{
return resolver.hasMethodPatterns() ? resolver : WILDCARD;
}
public final boolean isWildcard()
{
return equals( WILDCARD );
}
```
so:
```java
TestListResolver filter = optionallyWildcardFilter( resolver );
// this expression will always true - or I don't see something
!filter.isWildcard() == resolver.hasMethodPatterns()
```
and is it possible?
```java
resolver.hasMethodPatterns() == true && resolver.isEmpty() == true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
