Tibor17 commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833126518
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest
buildLauncherDiscoveryRequestForRerunFailures(
.map( TagFilter::excludeTags )
.ifPresent( filters::add );
- TestListResolver testListResolver =
parameters.getTestRequest().getTestListResolver();
- if ( !testListResolver.isEmpty() )
+ TestListResolver filter = optionallyWildcardFilter(
parameters.getTestRequest().getTestListResolver() );
+ if ( !filter.isEmpty() && !filter.isWildcard() )
Review comment:
Hi @slawekjaranowski ,
Regarding `return resolver.hasMethodPatterns() ? resolver : WILDCARD;` it
won't be right because there are many patterns, and not only method patterns,
there are also class patterns. So, this proposal won't work properly. Thx for
this remark.
The reason why we call `optionallyWildcardFilter()` is the fact we do not
need to care about filtering if it is empty or wildcard however it is a
difference for the `TestListResolver` itself but no difference for provider
purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
