slawekjaranowski commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832883253
########## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ########## @@ -0,0 +1,78 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.example</groupId> + <artifactId>junit5-suite</artifactId> + <version>1.0-SNAPSHOT</version> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>${java.specification.version}</maven.compiler.source> + <maven.compiler.target>${java.specification.version}</maven.compiler.target> + </properties> + + <dependencies> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-api</artifactId> + <version>5.8.0</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.junit.platform</groupId> + <artifactId>junit-platform-suite-api</artifactId> + <version>1.8.0</version> + <scope>test</scope> + </dependency> + </dependencies> + + <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>${surefire.version}</version> + <configuration> + <test>JUnit5Tests</test> + </configuration> + <dependencies> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <version>5.8.2</version> Review comment: In project dependency we have `junit-jupiter-api:5.8.0` but here `junit-jupiter-enginer:5.8.2` shouldn't they be the same version? ########## File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm ########## @@ -411,6 +413,41 @@ Using JUnit 5 Platform </dependencies> +---+ +** JUnit5 Suite + + For more information see this + {{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}} + and the {{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}. + ++---+ +<dependencies> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <version>5.8.2</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.junit.platform</groupId> + <artifactId>junit-platform-suite-engine</artifactId> + <version>1.8.2</version> + <scope>test</scope> + </dependency> +</dependencies> +<build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>${project.version}</version> + <configuration> + <test>JUnit5Tests</test> Review comment: We need describe what it is. People many times simply copy example to their project. Maybe something like: ```xml <test><!-- your suite test --></test> ``` ########## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ########## @@ -275,10 +276,10 @@ private LauncherDiscoveryRequest buildLauncherDiscoveryRequestForRerunFailures( .map( TagFilter::excludeTags ) .ifPresent( filters::add ); - TestListResolver testListResolver = parameters.getTestRequest().getTestListResolver(); - if ( !testListResolver.isEmpty() ) + TestListResolver filter = optionallyWildcardFilter( parameters.getTestRequest().getTestListResolver() ); + if ( !filter.isEmpty() && !filter.isWildcard() ) Review comment: It is not the same: ``` TestListResolver testListResolver = parameters.getTestRequest().getTestListResolver(); if ( testListResolver.hasMethodPatterns() ) ... ``` if true IT test doesn't cover this `if` with param `<test>JUnit5Tests</test>` For such change we should add unit test in `JUnitPlatformProviderTest` with assertions for filters ... Another case you change logic here .. but all unit test still pass, looks like missing tests or assertions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
