Tibor17 commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833335827
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest
buildLauncherDiscoveryRequestForRerunFailures(
.map( TagFilter::excludeTags )
.ifPresent( filters::add );
- TestListResolver testListResolver =
parameters.getTestRequest().getTestListResolver();
- if ( !testListResolver.isEmpty() )
+ TestListResolver filter = optionallyWildcardFilter(
parameters.getTestRequest().getTestListResolver() );
+ if ( !filter.isEmpty() && !filter.isWildcard() )
Review comment:
@slawekjaranowski
I guess `JUnitPlatformProviderTest` has similar use case which we can copy
and adapt, this may help. This could be done in advance, your right. Please
help me and push a new commit with the test if you have some spare time.
Yesterday and today I am supporting Olivier with testing on a demo project. I
would like to cut the release, the jdk 18 GA will be released soon as well and
we have jdk 18 related fixes.
Ah, i forgot, we may use the latest MPOM, do you have experiences with the
latest version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
