Tibor17 commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r832996983
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest
buildLauncherDiscoveryRequestForRerunFailures(
.map( TagFilter::excludeTags )
.ifPresent( filters::add );
- TestListResolver testListResolver =
parameters.getTestRequest().getTestListResolver();
- if ( !testListResolver.isEmpty() )
+ TestListResolver filter = optionallyWildcardFilter(
parameters.getTestRequest().getTestListResolver() );
+ if ( !filter.isEmpty() && !filter.isWildcard() )
Review comment:
@slawekjaranowski
No it is not same. See the other Providers -> JUnit4Provider
https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java#L436
and JUnitCoreProvider
https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreProvider.java#L274
It is there sine 2015, i.e. 7 years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
