Tibor17 commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833155118
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest
buildLauncherDiscoveryRequestForRerunFailures(
.map( TagFilter::excludeTags )
.ifPresent( filters::add );
- TestListResolver testListResolver =
parameters.getTestRequest().getTestListResolver();
- if ( !testListResolver.isEmpty() )
+ TestListResolver filter = optionallyWildcardFilter(
parameters.getTestRequest().getTestListResolver() );
+ if ( !filter.isEmpty() && !filter.isWildcard() )
Review comment:
We are again in the discussions with refactoring other providers. But
this issue is about Junit5 provider. So my goal is not to make all these
providers very different. I have made them similar in this PR through
JunitPlatformProvider changes and nowhere else. I am not interested in others
yet.
The `optionallyWildcardFilter()` can be removed but the condition can be
changed in the next PR, i.e. `!filter.isEmpty() && !filter.isWildcard() &&
!filter.hasMethodPatterns()`. Here I am trying to make a fix and not to make
providers too different in terms of filtering. Feel free to open a new PR after
this and you can change all providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
