Tibor17 commented on a change in pull request #491: URL: https://github.com/apache/maven-surefire/pull/491#discussion_r833757390
########## File path: pom.xml ########## @@ -371,48 +370,22 @@ <pluginManagement> <plugins> <plugin> + <!-- TODO remove with next parent --> <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-shade-plugin</artifactId> - <version>3.2.4</version><!-- TODO remove when upgrading parent to 35 --> + <artifactId>maven-pmd-plugin</artifactId> + <version>3.16.0</version> + </plugin> + <plugin> + <!-- TODO remove with next parent --> + <groupId>org.codehaus.mojo</groupId> + <artifactId>taglist-maven-plugin</artifactId> + <version>3.0.0</version> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-compiler-plugin</artifactId> - <executions> Review comment: @slawekjaranowski Do you have `<arg>-Xdoclint:all</arg>` in your commit? Is it in MPOM? The point is to get the error within compile time because this is what the contributors usualy do. They do not run `mvn site`. All of them run the normal build as they have experiences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org