[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

[GitBox]

Tibor17 commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833686568



##########
File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest 
buildLauncherDiscoveryRequestForRerunFailures(
                 .map( TagFilter::excludeTags )
                 .ifPresent( filters::add );
 
-        TestListResolver testListResolver = 
parameters.getTestRequest().getTestListResolver();
-        if ( !testListResolver.isEmpty() )
+        TestListResolver filter = optionallyWildcardFilter( 
parameters.getTestRequest().getTestListResolver() );
+        if ( !filter.isEmpty() && !filter.isWildcard() )

Review comment:
       @slawekjaranowski 
   I approved #491  maybe too early, we need to check the Javadoc by the 
compiler with `<arg>-Xdoclint:all</arg>`. Checking it during Site is too late. 
The contributors can check it by usual build `mvn install`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org