Tibor17 commented on a change in pull request #494:
URL: https://github.com/apache/maven-surefire/pull/494#discussion_r833818854
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -275,10 +276,10 @@ private LauncherDiscoveryRequest
buildLauncherDiscoveryRequestForRerunFailures(
.map( TagFilter::excludeTags )
.ifPresent( filters::add );
- TestListResolver testListResolver =
parameters.getTestRequest().getTestListResolver();
- if ( !testListResolver.isEmpty() )
+ TestListResolver filter = optionallyWildcardFilter(
parameters.getTestRequest().getTestListResolver() );
+ if ( !filter.isEmpty() && !filter.isWildcard() )
Review comment:
> As I understand getTestListResolver() returns TestListResolver with
informations based on -Dtest param.
It also has some form of merged patterns includes/excludes,
includeFile/excludeFile.
If you remember SUREFIRE-1426 with ildefonso and Olivier, that's exactly the
part of code which updated the merge logic.
> test=xxxx then filters.contains or filters.notContains some of
TestMethodFilter instance or another filter instance which should be added for
given -Dtest
Yes, I think the same, it would be enough to test `newFilters()` and verify
the collection content. I found some example which would help you, and you can
reuse it, see the test method `onlyGroupsIsDeclared()` in the test
`JUnitPlatformProviderTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
