Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra merged PR #10001: URL: https://github.com/apache/iceberg/pull/10001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1537915830 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -304,23 +310,13 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1537915830 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -304,23 +310,13 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1537175702 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -304,23 +310,13 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535437170 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java: ## @@ -1041,7 +1041,7 @@ public void testNotExposeTableProperties() { .doesNotCo

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535436900 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java: ## @@ -1041,7 +1041,7 @@ public void testNotExposeTableProperties() { .doesNotCo

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535422769 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -457,6 +448,16 @@ public String table() { return tableName; } + @Ove

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535422346 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -365,6 +353,10 @@ private void setHmsTableParameters( } // Set the

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535422346 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -365,6 +353,10 @@ private void setHmsTableParameters( } // Set the

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535421842 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -304,30 +305,16 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535420615 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -304,30 +305,16 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535419303 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -123,13 +185,14 @@ default void persistTable(Table hmsTable, boolean updateHive

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535418537 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -76,11 +138,11 @@ default boolean exposeInHmsProperties() { return maxHiveT

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535416777 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -62,6 +82,48 @@ interface HiveOperationsBase { String table(); + String

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535406841 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -62,6 +82,48 @@ interface HiveOperationsBase { String table(); + String

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535407624 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -62,6 +82,48 @@ interface HiveOperationsBase { String table(); + String

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535393968 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -273,6 +284,21 @@ public void renameTable(TableIdentifier from, TableIdentifier origin

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535393632 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -273,6 +284,21 @@ public void renameTable(TableIdentifier from, TableIdentifier origin

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535393422 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -239,7 +250,7 @@ public void renameTable(TableIdentifier from, TableIdentifier origina

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535389326 ## core/src/test/java/org/apache/iceberg/TestCatalogUtil.java: ## @@ -223,6 +223,32 @@ public void loadCustomMetricsReporter_badClass() { .hasMessageContainin

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535389035 ## core/src/test/java/org/apache/iceberg/TestCatalogUtil.java: ## @@ -223,6 +223,32 @@ public void loadCustomMetricsReporter_badClass() { .hasMessageContainin

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535385693 ## core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533819440 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -282,7 +281,12 @@ protected void doCommit(TableMetadata base, TableMetadata me

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533818010 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533741453 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -304,30 +305,16 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533738195 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -240,9 +239,9 @@ protected void doCommit(TableMetadata base, TableMetadata met

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533723838 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533719987 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,9 +211,29 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533712833 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533702231 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -136,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { deleteFi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533432188 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -166,168 +159,36 @@ protected void doRefresh() { refreshFromMetadataLocati

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533430710 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -181,4 +272,203 @@ default Table newHmsTable(String hmsTableOwner) { retu

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533422080 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -139,22 +212,40 @@ static StorageDescriptor storageDescriptor(TableMetadata met

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533419675 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -139,22 +212,40 @@ static StorageDescriptor storageDescriptor(TableMetadata met

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533415487 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,7 +259,7 @@ public void renameTable(TableIdentifier from, TableIdentifier origina

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533414139 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,9 +211,29 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533412107 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,9 +211,29 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533411887 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -273,6 +282,21 @@ public void renameTable(TableIdentifier from, TableIdentifier origin

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533378904 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -136,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { deleteFi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533378394 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533376457 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533376150 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533372773 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -291,6 +284,8 @@ public long newSnapshotId() { }; } + /** @deprecated Use

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533370990 ## core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533369953 ## core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on PR #10001: URL: https://github.com/apache/iceberg/pull/10001#issuecomment-2011254887 @nastra , Please let me know if there are more comments ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530379477 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +264,66 @@ public void renameTable(TableIdentifier from, TableIdentifier origi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530375282 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -169,8 +260,8 @@ default Table newHmsTable(String hmsTableOwner) {

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530321209 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530317976 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -169,8 +260,8 @@ default Table newHmsTable(String hmsTableOwner) {

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530154379 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -169,8 +260,8 @@ default Table newHmsTable(String hmsTableOwner) {

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530152090 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +264,66 @@ public void renameTable(TableIdentifier from, TableIdentifier origi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530149331 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,24 +214,46 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530146675 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,24 +214,46 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530145798 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,24 +214,46 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530141957 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -136,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { deleteFi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nastra commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530138582 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529998283 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -166,168 +159,36 @@ protected void doRefresh() { refreshFromMetadataLocati

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529997210 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -181,4 +272,203 @@ default Table newHmsTable(String hmsTableOwner) { retu

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529993318 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +264,66 @@ public void renameTable(TableIdentifier from, TableIdentifier origi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529992108 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,24 +214,46 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529991722 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,24 +214,46 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529989675 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HMSParametersSetter.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529989675 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HMSParametersSetter.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529985583 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -136,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { deleteFi

Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

nk1506 commented on code in PR #10001: URL: https://github.com/apache/iceberg/pull/10001#discussion_r1529983789 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,39 @@ protected enum CommitStatus { * @return Commit Status of Succe