nk1506 commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533719987
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -222,9 +211,29 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
@Override
public void renameTable(TableIdentifier from, TableIdentifier originalTo) {
- if (!isValidIdentifier(from)) {
- throw new NoSuchTableException("Invalid identifier: %s", from);
- }
+ renameContent(from, originalTo, HiveOperationsBase.ContentType.TABLE);
+ }
+
+ private List<TableIdentifier> listIcebergTables(
+ List<String> tableNames, Namespace namespace, String tableTypeProp)
+ throws TException, InterruptedException {
+ List<Table> tableObjects =
+ clients.run(client -> client.getTableObjectsByName(namespace.level(0),
tableNames));
+ return tableObjects.stream()
+ .filter(
+ table ->
+ table.getParameters() != null
+ && tableTypeProp.equalsIgnoreCase(
+
table.getParameters().get(BaseMetastoreTableOperations.TABLE_TYPE_PROP)))
+ .map(table -> TableIdentifier.of(namespace, table.getTableName()))
+ .collect(Collectors.toList());
+ }
+
+ private void renameContent(
+ TableIdentifier from,
+ TableIdentifier originalTo,
+ HiveOperationsBase.ContentType contentType) {
+ Preconditions.checkArgument(isValidIdentifier(from), "Invalid identifier:
%s", from);
Review Comment:
Intent here was to have common exception for `Table/View`. But I think with
`View` impl we will have to revisit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
