nk1506 commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1537915830
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -304,23 +310,13 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
throw new CommitFailedException(e);
} finally {
- cleanupMetadataAndUnlock(commitStatus, newMetadataLocation, lock);
+ HiveOperationsBase.cleanupMetadataAndUnlock(io(), commitStatus,
newMetadataLocation, lock);
Review Comment:
It expects interface with static method . Plz let me know if you think other
way around.
<img width="1111" alt="Screenshot 2024-03-25 at 10 21 00 PM"
src="https://github.com/apache/iceberg/assets/4146188/9d1f4f78-c607-41f2-9c10-04138c74a566";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
