nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535406841
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -62,6 +82,48 @@ interface HiveOperationsBase {
String table();
+ String catalogName();
Review Comment:
I don't think we should be introducing `catalogName()`/ `contentType()` to
this API just for printing it in a `TRACE` log inside `loadHmsTable()`. Please
remove `catalogName()`/ `contentType()` from this API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
