nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1533419675
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -139,22 +212,40 @@ static StorageDescriptor storageDescriptor(TableMetadata
metadata, boolean hiveE
storageDescriptor.setInputFormat("org.apache.hadoop.mapred.FileInputFormat");
serDeInfo.setSerializationLib("org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe");
}
+
storageDescriptor.setSerdeInfo(serDeInfo);
return storageDescriptor;
}
- static void cleanupMetadata(FileIO io, String commitStatus, String
metadataLocation) {
+ default void cleanupMetadataAndUnlock(
Review Comment:
I would probably just leave `cleanupMetadata` as it is and introduce
`cleanupMetadataAndUnlock()` as a separate method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
