Re: [PR] Hive: Arrange common part of the code for Iceberg View. [iceberg]

[via GitHub]

nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530149331


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -222,24 +214,46 @@ public boolean dropTable(TableIdentifier identifier, 
boolean purge) {
 
   @Override
   public void renameTable(TableIdentifier from, TableIdentifier originalTo) {
-    if (!isValidIdentifier(from)) {
-      throw new NoSuchTableException("Invalid identifier: %s", from);
-    }
+    renameContent(from, originalTo, HiveOperationsBase.ContentType.TABLE);
+  }
 
-    TableIdentifier to = removeCatalogName(originalTo);
+  private List<TableIdentifier> filterIcebergEntities(
+      List<String> tableNames, Namespace namespace, String tableTypeProp)
+      throws TException, InterruptedException {
+    List<Table> tableObjects =
+        clients.run(client -> client.getTableObjectsByName(namespace.level(0), 
tableNames));
+    return tableObjects.stream()
+        .filter(
+            table ->
+                table.getParameters() != null
+                    && tableTypeProp.equalsIgnoreCase(
+                        
table.getParameters().get(BaseMetastoreTableOperations.TABLE_TYPE_PROP)))
+        .map(table -> TableIdentifier.of(namespace, table.getTableName()))
+        .collect(Collectors.toList());
+  }
+
+  private void renameContent(
+      TableIdentifier fromIdentifier,
+      TableIdentifier toIdentifier,
+      HiveOperationsBase.ContentType contentType) {
+    Preconditions.checkArgument(
+        isValidIdentifier(fromIdentifier), "Invalid identifier: %s", 
fromIdentifier);
+
+    TableIdentifier to = removeCatalogName(toIdentifier);
     Preconditions.checkArgument(isValidIdentifier(to), "Invalid identifier: 
%s", to);
     if (!namespaceExists(to.namespace())) {
       throw new NoSuchNamespaceException(
-          "Cannot rename %s to %s. Namespace does not exist: %s", from, to, 
to.namespace());
+          "Cannot rename %s to %s. Namespace does not exist: %s",
+          fromIdentifier, to, to.namespace());
     }
 
     String toDatabase = to.namespace().level(0);
-    String fromDatabase = from.namespace().level(0);
-    String fromName = from.name();
+    String fromDatabase = fromIdentifier.namespace().level(0);

Review Comment:
   ```suggestion
       String fromDatabase = from.namespace().level(0);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org