nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535420615
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -304,30 +305,16 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
throw new CommitFailedException(e);
} finally {
- cleanupMetadataAndUnlock(commitStatus, newMetadataLocation, lock);
+ HiveOperationsBase.cleanupMetadataAndUnlock(io(), commitStatus,
newMetadataLocation, lock);
}
LOG.info(
"Committed to table {} with the new metadata location {}", fullName,
newMetadataLocation);
}
- @VisibleForTesting
- Table loadHmsTable() throws TException, InterruptedException {
- try {
- return metaClients.run(client -> client.getTable(database, tableName));
- } catch (NoSuchObjectException nte) {
- LOG.trace("Table not found {}", fullName, nte);
- return null;
- }
- }
+ public void setHmsParameters(
+ TableMetadata metadata, Table tbl, String newMetadataLocation,
Set<String> obsoleteProps) {
- private void setHmsTableParameters(
Review Comment:
please revert these changes
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -304,30 +305,16 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
throw new CommitFailedException(e);
} finally {
- cleanupMetadataAndUnlock(commitStatus, newMetadataLocation, lock);
+ HiveOperationsBase.cleanupMetadataAndUnlock(io(), commitStatus,
newMetadataLocation, lock);
}
LOG.info(
"Committed to table {} with the new metadata location {}", fullName,
newMetadataLocation);
}
- @VisibleForTesting
- Table loadHmsTable() throws TException, InterruptedException {
- try {
- return metaClients.run(client -> client.getTable(database, tableName));
- } catch (NoSuchObjectException nte) {
- LOG.trace("Table not found {}", fullName, nte);
- return null;
- }
- }
+ public void setHmsParameters(
+ TableMetadata metadata, Table tbl, String newMetadataLocation,
Set<String> obsoleteProps) {
- private void setHmsTableParameters(
Review Comment:
please revert these changes in this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
