nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530375282
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -169,8 +260,8 @@ default Table newHmsTable(String hmsTableOwner) {
null,
Collections.emptyList(),
Maps.newHashMap(),
- null,
- null,
+ properties.getOrDefault(HiveCatalog.VIEW_ORIGINAL_TEXT, null),
Review Comment:
I think this PR should be a pure refactoring and not add new
things/functionality. The current code on `main` doesn't look at this property,
so why do we need to check this property as part of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
