nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535419303
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -123,13 +185,14 @@ default void persistTable(Table hmsTable, boolean
updateHiveTable, String metada
}
}
- static StorageDescriptor storageDescriptor(TableMetadata metadata, boolean
hiveEngineEnabled) {
Review Comment:
same as above, we need to keep `StorageDescriptor
storageDescriptor(TableMetadata metadata, boolean hiveEngineEnabled)` but it
can internally call `static StorageDescriptor storageDescriptor(Schema schema,
String location, boolean hiveEngineEnabled)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
